Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0.X] Introduce reco::Track::recHitsOk() and use it to remove try/catch pattern in SingleLongTrackProducer #45230

Merged
merged 2 commits into from
Jun 24, 2024
Merged

[14.0.X] Introduce reco::Track::recHitsOk() and use it to remove try/catch pattern in SingleLongTrackProducer #45230

merged 2 commits into from
Jun 24, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 15, 2024

backport of #45213

PR description:

This PR addresses this #45162 (comment), by introducing a new helper method reco::Track::recHitsOk() to check the rechits availability content of the input tracks in the track selection logic of SingleLongTrackProducer.
This allows to remove a try/catch pattern in it, causing lots of extraneous exceptions being thrown (and caught) in prompt reco jobs, as reported initially in the issue #45162. The implementation (from @borzari) follows the suggestion here #45162 (comment).
I profit of this PR to refactor the track selection in SingleLongTrackProducer to avoid filling the selTracks with tracks without reco::Track::Extra attached to them.

PR validation:

could run this test:

cmssw/DQM/TrackingMonitorSource/test/BuildFile.xml

Line 2 in 4639c10

<test name="testTrackingResolution" command="testTrackingResolution.sh"/>

(even using the whole input file) without crashes.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #45213 to CMSSW_14_0_X for data-taking purposes.

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Jun 15, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 15, 2024 •
edited
Loading

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • DataFormats/TrackReco (reconstruction)
  • RecoTracker/FinalTrackSelectors (reconstruction)

@cmsbuild, @mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@felicepantaleo, @VourMa, @missirol, @JanFSchulte, @mmusich, @dgulhan, @GiacomoSguazzoni, @gpetruc, @mtosi, @VinInn, @rovere this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 15, 2024 •
edited
Loading

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Jun 15, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f86b94/39902/summary.html
COMMIT: 2741744
CMSSW: CMSSW_14_0_X_2024-06-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45230/39902/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

urgent

@mmusich
Copy link
Contributor Author

mmusich commented Jun 24, 2024

@cms-sw/orp-l2 what's the plan for integration of this PR?

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6676ac1 into cms-sw:CMSSW_14_0_X Jun 24, 2024
10 checks passed
@mmusich mmusich deleted the rmTryCatch_from_borzari_14_0_X branch June 24, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok fully-signed orp-approved reconstruction-approved tests-approved tracking urgent
Projects
None yet
Milestone
CMSSW_14_0_X
Development

Successfully merging this pull request may close these issues.
5 participants
@mmusich @cmsbuild @mandrenguyen @antoniovilela @borzari